[PM-25820] Return DeleteAttachmentResponseModel from cipher attachment delete endpoints#7013
Merged
gbubemismith merged 3 commits intomainfrom Feb 17, 2026
Merged
Conversation
gbubemismith
requested review from
nick-livefront,
nikwithak and
shane-melton
Contributor
|
New Issues (1)Checkmarx found the following issues in this Pull Request
|
nick-livefront
approved these changes
Feb 17, 2026
shane-melton
approved these changes
Feb 17, 2026
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7013 +/- ##
==========================================
- Coverage 56.48% 56.48% -0.01%
==========================================
Files 2002 2003 +1
Lines 88314 88318 +4
Branches 7892 7892
==========================================
+ Hits 49887 49888 +1
- Misses 36586 36589 +3
Partials 1841 1841 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-25820
📔 Objective
Updates the
DeleteAttachmentandDeleteAttachmentAdminendpoints to return a DeleteAttachmentResponseModel instead of returningDeleteAttachmentResponseDatawhich contained the cipher entity.📸 Screenshots